refactor: Add OptionsModel getOption/setOption methods #600
Conversation
Easiest to review ignoring whitespace.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| successful = setOption(OptionID(index.row()), value); | ||
| } | ||
|
|
||
| Q_EMIT dataChanged(index, index); |
There was a problem hiding this comment.
Not for this PR but we actually don't need to call dataChanged if nothing changed inside setOption (which can happen if the new value is the same as the stored one or if something bad happened internally, like a bad parsing or a impossibility to store the new value).
| } | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
I wonder if it should set successful = false? Or maybe just drop the default cases and let the compiler complain about unhandled cases?
| successful = setOption(OptionID(index.row()), value); | ||
| } | ||
|
|
||
| Q_EMIT dataChanged(index, index); |
This is a trivial change which is needed as part of #602 to get bitcoind and bitcoin-qt to use the same settings instead of different settings. It is split off from #602 because it causes a lot of rebase conflicts (any time there is a GUI options change).
This PR is very small and easy to review ignoring whitespace: https://github.com/bitcoin-core/gui/pull/600/files?w=1