Fixes to allow building with msvc. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Dec 1, 2017
| @@ -32,9 +32,16 @@ | |||
| #define STORAGE_LEVELDB_PORT_PORT_WIN_H_ | |||
|
|
|||
| #ifdef _MSC_VER | |||
| #if !(_MSC_VER >= 1900) | |||
There was a problem hiding this comment.
I think that would be clearer as _MSC_VER < 1900.
There was a problem hiding this comment.
It looks like #7 has extended fix for it.
|
tACK, we are using this for our windows build. |
|
tACK d6eab93 |
12 tasks
laanwj
added a commit
that referenced
this pull request
Jan 16, 2019
d6eab93 Fixes to allow building with msvc. (Aaron Clauson) Pull request description: This PR would be very handy to facilitate building bitcoin with msvc. The [relevant parts of the patch were submitted](google#521) upstream to the main leveldb source but there looks to be a bigger Windows port going on there at the moment. Tree-SHA512: 0183c6fb189ee3446c2de1f02b514dcb77b2e1d6524e127be2e396575eb6106e1081143b4b5a2a91c9cc8424dfcfc0230c4b4c55db6a66dceb6f61fb89f90f5a
This was referenced Jan 16, 2019
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 31, 2019
82dcacb msvc: build leveldb locally (Chun Kuan Lee) 5209106 msvc: build secp256k1 locally (Chun Kuan Lee) Pull request description: In current MSVC build setup, the code depends on leveldb and secp256k1 that are installed from vcpkg which is not controlled by us. If we update our code, we have to wait for vcpkg port being merged. This PR move them from vcpkg to local branch to make it as same as autoconf. The leveldb changes is based on bitcoin-core/leveldb-subtree#14 and bitcoin-core/leveldb-subtree#18 Tree-SHA512: aa2cc1c3191e8d9cab23d555da4be296314c46d944f452c2ec6202b1779e4cc223b603e589b38196cd2c793a03a8bb0ba128cc66256b35a58c5e7bb358475206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would be very handy to facilitate building bitcoin with msvc.
The relevant parts of the patch were submitted upstream to the main leveldb source but there looks to be a bigger Windows port going on there at the moment.