Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a big fat disclaimer README.md #3

Closed
sipa opened this issue Mar 26, 2014 · 1 comment
Closed

Write a big fat disclaimer README.md #3

sipa opened this issue Mar 26, 2014 · 1 comment

Comments

@sipa
Copy link
Contributor

sipa commented Mar 26, 2014

This library is experimental, use at your own risk, ...
@sipa
Copy link
Contributor Author

sipa commented Jun 15, 2014

Done.

@sipa sipa closed this as completed Jun 15, 2014
benma added a commit to benma/secp256k1 that referenced this issue Jul 15, 2019
@benma @douglasbakkum
ecmult_static_context.h: add compile time config assertion (bitcoin-c…
7abe39b 
…ore#3)

Prevents accidentally using a file which was generated with a
different configuration.
real-or-random pushed a commit that referenced this issue Sep 5, 2019
@douglasbakkum
variable signing precompute table
dcb2e3b 
make ECMULT_GEN_PREC_BITS configurable

ecmult_static_context.h: add compile time config assertion (#3) - Prevents accidentally using a file which was generated with a
different configuration.

README: mention valgrind issue

With --with-ecmult-gen-precision=8, valgrind needs a max stack size
adjustment to not run into a stack switching heuristic:

http://valgrind.org/docs/manual/manual-core.html

> -max-stackframe= [default: 2000000]
> The maximum size of a stack frame. If the stack pointer moves by more than this amount then Valgrind will assume that the program is switching to a different stack.
You may need to use this option if your program has large stack-allocated arrays.

basic-config: undef ECMULT_WINDOW_SIZE before (re-)defining it
evoskuil pushed a commit to evoskuil/secp256k1 that referenced this issue Oct 28, 2019
@pmienk
Merge pull request bitcoin-core#3 from pmienk/master
2bdb307 
Correct order of libs returned on pkg-config --libs --static libsecp2…
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 14, 2020
@nkohen
Merge pull request bitcoin-core#3 from nkohen/add-bitcion-s-jni
1a3934e 
Update Bitcoin-S libsecp
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 14, 2020
@nkohen
Merge pull request bitcoin-core#3 from nkohen/add-bitcion-s-jni
359f529 
Update Bitcoin-S libsecp
real-or-random added a commit that referenced this issue Jun 24, 2024
@real-or-random
Merge #1545: cmake: Do not set CTEST_TEST_TARGET_ALIAS
69b2192 
f87a358 cmake: Do not set `CTEST_TEST_TARGET_ALIAS` (Hennadii Stepanov)

Pull request description:

  An alias for the "test" target can be confusing for the downstream project.

  For instance, when integrating using `add_subdirectory(secp256k1 EXCLUDE_FROM_ALL)` (see hebasto/bitcoin#192), test binaries are not being built by default. But the `check` alias target is exposed to the downstream project build system, which in turn fails:
  ```
  $ make -C build check
  ...
  Unable to find executable: /home/hebasto/git/bitcoin/build/src/secp256k1/src/exhaustive_tests
  3/3 Test #3: exhaustive_tests .................***Not Run   0.00 sec

  0% tests passed, 3 tests failed out of 3

  Total Test time (real) =   0.03 sec

  The following tests FAILED:
    1 - noverify_tests (Not Run)
    2 - tests (Not Run)
    3 - exhaustive_tests (Not Run)
  Errors while running CTest
  ...
  ```

  This PR fixes this issue by deleting the `CTEST_TEST_TARGET_ALIAS` usage.

ACKs for top commit:
  real-or-random:
    utACK f87a358

Tree-SHA512: ccf3f30939cf1747471ea15260f7caa6dad3f510e5771245ecbfbef3cc0b0e7c8ac551519d0892bf2544c91467d8d67d2c6e6bc52f56c384b174b88bcf377d4a
Cheapshot003 added a commit to Cheapshot003/secp256k1 that referenced this issue Aug 29, 2024
@Cheapshot003
improving examples bitcoin-core#3: changing comments
edb863d
Cheapshot003 added a commit to Cheapshot003/secp256k1 that referenced this issue Sep 3, 2024
@Cheapshot003
Improve examples: remove key generation loops
3e8170c 
improving examples bitcoin-core#2: fixing my mistakes; changing comments

improving examples bitcoin-core#3: changing comments

fixing syntax - adjustment to schnorr examples

fixing comments

fix schnorr signature tests
real-or-random added a commit that referenced this issue Oct 29, 2024
@real-or-random
Merge #1582: cmake, test: Add secp256k1_ prefix to test names
9a8db52 
87384f5 cmake, test: Add `secp256k1_` prefix to test names (Hennadii Stepanov)

Pull request description:

  This PR improves regex matching options when using `ctest` in downstream projects, such as Bitcoin Core.

  For instance, a downstream project users can filter their tests like that:
  ```
  ctest --tests-regex "secp256k1"
  ```
  or
  ```
  ctest --exclude-regex "secp256k1"
  ```

  A `ctest` log with this PR:
  ```
  $ ctest --test-dir build -j 16
  Internal ctest changing into directory: /home/hebasto/git/secp256k1/secp256k1/build
  Test project /home/hebasto/git/secp256k1/secp256k1/build
      Start 1: secp256k1_noverify_tests
      Start 2: secp256k1_tests
      Start 3: secp256k1_exhaustive_tests
      Start 4: secp256k1_ecdsa_example
      Start 5: secp256k1_ecdh_example
      Start 6: secp256k1_schnorr_example
      Start 7: secp256k1_ellswift_example
      Start 8: secp256k1_musig_example
  1/8 Test #4: secp256k1_ecdsa_example ..........   Passed    0.00 sec
  2/8 Test #5: secp256k1_ecdh_example ...........   Passed    0.00 sec
  3/8 Test #6: secp256k1_schnorr_example ........   Passed    0.00 sec
  4/8 Test #7: secp256k1_ellswift_example .......   Passed    0.00 sec
  5/8 Test #8: secp256k1_musig_example ..........   Passed    0.00 sec
  6/8 Test #3: secp256k1_exhaustive_tests .......   Passed    6.19 sec
  7/8 Test #1: secp256k1_noverify_tests .........   Passed   38.83 sec
  8/8 Test #2: secp256k1_tests ..................   Passed   91.66 sec

  100% tests passed, 0 tests failed out of 8

  Total Test time (real) =  91.67 sec
  ```

ACKs for top commit:
  theuni:
    utACK 87384f5
  real-or-random:
    utACK 87384f5

Tree-SHA512: d8e46558cf58c9c660544b7bdfed24c991eb3e120b6511aa3968f509190130e498749a3c4dbabc87a7f22f0aa0056c6bcd3fc6c44f5eb131588945d593546840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sipa