Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BIP 118 validation (SIGHASH_ANYPREVOUT) #67

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Implement BIP 118 validation (SIGHASH_ANYPREVOUT) #67

merged 9 commits into from
Oct 9, 2024

Commits on Oct 9, 2024

  1. script/interpreter: Add KeyVersion 

    Introduce `KeyVersion` in preparation for defining new behaviours via
BIP 342's "unknown public key type" upgrade mechanism.
    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d81afc3 View commit details
    Browse the repository at this point in the history

  2. Implement BIP 118 (SIGHASH_ANYPREVOUT)

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    50d4a78 View commit details
    Browse the repository at this point in the history

  3. bitcoin-util: update for ipk in ScriptExecutionData

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    37a940a View commit details
    Browse the repository at this point in the history

  4. tests: Add unit tests for ANYPREVOUT

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    089ff2f View commit details
    Browse the repository at this point in the history

  5. tests: Update test framework for ANYPREVOUT

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9303420 View commit details
    Browse the repository at this point in the history

  6. Add ANYPREVOUT deployment

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7441e0e View commit details
    Browse the repository at this point in the history

  7. Make ANYPREVOUT transactions standard after activation

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fe4ea2d View commit details
    Browse the repository at this point in the history

  8. tests: Add ANYPREVOUT testing to feature_taproot

    @ajtowns
    ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    63b2f8a View commit details
    Browse the repository at this point in the history

  9. qa: add a fuzz target ensuring the sighash behaviour for non APO keys… 

    … was conserved

This fuzz targets copied the SignatureHashSchnorr function for Bitcoin
Core 23.0 and checks the output of the APO-ready SignatureHashSchnorr
from this branch against it.

This is to make sure the behaviour of the function was not changed for
non ANYPREVOUT keys, which would make some previously valid signatures
invalid and, even worse, some previously invalid signatures valid.
    @darosior @ajtowns
    darosior authored and ajtowns committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cd5e10e View commit details
    Browse the repository at this point in the history