Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP341: add aux_rand argument to taproot_sign_key #1379

Merged
merged 1 commit into from
Jan 4, 2023
Merged

BIP341: add aux_rand argument to taproot_sign_key #1379

merged 1 commit into from
Jan 4, 2023

Conversation

DariusParvin
Copy link
Contributor

@DariusParvin DariusParvin commented Oct 9, 2022 •
edited
Loading

The schnorr_sign function from the bip340 reference code has a third required argument aux_rand: bytes.

Change:

  • adding aux_rand as an optional argument that defaults to 0x0000...
  • adding bip340_aux_rand as a required argument to the function taproot_sign_key

jonasnick
jonasnick reviewed Oct 24, 2022
View reviewed changes
bip-0341.mediawiki Outdated Show resolved Hide resolved
jonasnick
jonasnick approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e24f685

Thanks @DariusParvin !

@sipa
Copy link
Member

sipa commented Nov 10, 2022

ACK e24f685

@kallewoof kallewoof merged commit 79bb53d into bitcoin:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DariusParvin @sipa @jonasnick @kallewoof