Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-00{43,49,84}: move to Standards Track + BIP-0044: mark as Final #1558

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Mar 18, 2024

I just noticed inconsistency between BIPs dealing with the account structures:

  • BIP-00{43,49,84} were Informational, while BIP-00{44,86} are Standards Track => this PR changes the former to the Standards Track too
  • BIP-0044 was not marked as Final where BIP-00{43,49,84,86} are => let's mark BIP-0044 as Final too

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luke-jr @achow101 thoughts?

@bitcoin bitcoin deleted a comment Apr 22, 2024
Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being able to import keys from one wallet in another wallet is a compatibility concern, so it makes sense to me for these BIPs to be Standard Track: ACK 5658236

Given that BIP44 has been implemented by at least 10 wallets, it is reasonable to move it to final. ACK 0278bf3

@murchandamus murchandamus merged commit 9ad691a into bitcoin:master Apr 22, 2024
3 checks passed
@achow101
Copy link
Member

ACK 0278bf3

@prusnak prusnak deleted the account-bips branch July 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants