BIP 32: Test vectors for leading zeros #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These additional test vectors will ensure all future implementations are interoperable. See iancoleman/bip39#58 and bitpay/bitcore-lib#47
|
ACK. I've verified these test vector myself by implementing them in Bitcoin Core's unit test framework. Thanks for figuring out the cause of the divergence between clients. |
schildbach
pushed a commit
to schildbach/bitcoinj
that referenced
this pull request
Feb 25, 2017
schildbach
pushed a commit
to schildbach/bitcoinj
that referenced
this pull request
Feb 25, 2017
|
ACK. I just added this test vector to bitcoinj (bitcoinj/bitcoinj#1342). |
braydonf
added a commit
to braydonf/btcjs
that referenced
this pull request
Mar 1, 2017
From vectors added in bitcoin/bips#497
|
ACK. Also added in bitpay/bitcore-lib#97 |
schildbach
pushed a commit
to bitcoinj/bitcoinj
that referenced
this pull request
Mar 6, 2017
schildbach
pushed a commit
to bitcoinj/bitcoinj
that referenced
this pull request
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional test vectors will ensure all future implementations are compliant with bip32.
See iancoleman/bip39#58 and bitpay/bitcore-lib#47
Possibly these test vectors may be useful also:
bitcoinjs-lib test for this issue
bitcore-lib test for this issue (pending merge)