tests: run sanity checks in tests too #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these are going to fail in bitcoind, they should fail in the tests as well.
|
ACK (although something could be said for putting the ECC test in key_tests instead, but ECC sanity is a core-enough concern to bitcoin that it makes sense as a general sanity check) |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jan 8, 2015
d58c5d6 tests: run sanity checks in tests too (Cory Fields)
|
Also cherry-picked to 0.10 as 263b65e |
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
If these are going to fail in bitcoind, they should fail in the tests as well. Github-Pull: bitcoin#5604 Rebased-From: d58c5d6 (cherry picked from commit 263b65e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently stumbled upon a bad compiler/libstdc++ runtime combination where these sanity checks fail in bitcoind. If they are going to fail in bitcoind, they should fail in the tests as well.
Confirmed failing as expected on this combination (osx 10.9 + vanilla clang 3.4 + macosx-version-min=10.8).