Small explora fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since default bitcoin network is testnet this change set default esplora server url to match.
Remove instructions with esplora feature and replace with esplora-ureq and esplora-reqwest features.
rajarshimaitra
suggested changes
Oct 5, 2021
There was a problem hiding this comment.
tACK cb17b5e
Verified that esplora sync is working with current changes.
6 tasks
|
ACK 1219fa5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://blockstream.info/testnet/apito match defaultbdk-clinetwork which is alsotestnet.esplora-ureqandesplora-reqest.Notes to the reviewers
I think this is the simplest way to fix the esplora server URL to match the specified bitcoin network. If the user uses the option to change the bitcoin network then they should also expect to change the esplora (or other blockchain client) server url.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing