[bug] Fix RPC tests #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this one needs a rebase also before it can be merged. |
rajarshimaitra
force-pushed
the
rpc-fix
branch
from
083a3e5
to
e3f3c3a
Compare
|
Rebased. |
|
re-ACK e3f3c3a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an inconsistency in
rpctests. TheRpcOptswas missing from the wallet struct. This wasn't caught before because we didn't haverpctests in CI. Fixed that too.Also removed redundant wallet options from feature gated tests.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing