Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] Add maybe_descriptor_wallet_name() in repl mode #82

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

rajarshimaitra
Copy link
Contributor

Description

Because we didn't had maybe_descriptor_wallet_name() in repl, the following command would fail

$ ./target/debug/bdk-cli repl -d "wpkh([b8b575c2/84'/1'/0'/0]tprv8icWtRzy9CWgFxpGMLSdAeE4wWyz39XGc6SwykeTo13tYm14JkVVQAf7jz8WDDarCgNJrG3aEPJEqchDWeJdiaWpS3FwbLB9SzsN57V7qxB/*)"
thread 'main' panicked at 'We should always have a wallet name at this point', src/bdk_cli.rs:116:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fd3f2b4

@notmandatory
Copy link
Member

I sneaked in a commit to also fix #78

@notmandatory notmandatory merged commit 50032ce into bitcoindevkit:master Mar 29, 2022
@notmandatory notmandatory added this to the Release 0.5.x milestone Mar 29, 2022
@thunderbiscuit
Copy link
Member

thunderbiscuit commented Mar 30, 2022

Thanks for this! Sorry I'm late to the party, but I use the repl most of the time and these are great fixes. 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants