Add coin selection methods #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
zoedberg
force-pushed
the
coin_selection
branch
2 times, most recently
from
7e92f41 to
5deafc8
Compare
|
@zoedberg I merged your PR for |
|
Overall looks good, I just have one small suggestion to eliminate an |
|
Thanks for the suggestion! :) rebased, fixed and pushed |
thunderbiscuit
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Tested a few of these in my bdk-kotlin-test-suite and everything seem to be working great!
Thanks for the PR @zoedberg, and your patience in getting this in.
ACK 24a0779.
|
ReACK a3ae463. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #131
please note this PR contains a commit adding the
list_unspentmethod for which a PR has already been opened, I'll rebase this once that has been merged.