-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation #171
Merged
Merged
Add documentation #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
added
the
documentation
Improvements or additions to documentation
label
Jul 15, 2022
Looks good ! I think you need to rebase to pickup recently merged #178 . |
Yeah I rebased earlier today. I think it's ready to go. |
notmandatory
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cd38001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's high time we document the Rust code.
Because we don't have official API docs at the moment (and we don't really know how long it will be before we can have them), I expect users will be referring to source code for documentation. Because we can't build those in the bindings files themselves at the moment, documenting the Rust code in bdk-ffi is a low hanging fruit that is probably worthy of our time.
This is currently in draft mode, but more or less I propose to try and pull from the official BDK Rust docs whenever the types are the same or the documentation applies, and write our own when needed. Here are examples for
AddressInfo
andAddressIndex
: