Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combine() method on PSBT #200

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Sep 28, 2022

This method adds the ability to combine two PSBTs.

Closes #198

Changelog notice

APIs Added:
    - Add `PartiallySignedBitcoinTransaction.combine()` method [#200]

[#200](https://github.com/bitcoindevkit/bdk-ffi/pull/200)

Notes to the reviewers

Please merge #199 before this one. I will update the changelog and add the commit once that's in.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8281915

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8281915

@thunderbiscuit thunderbiscuit merged commit c971d54 into bitcoindevkit:master Sep 30, 2022
@thunderbiscuit thunderbiscuit deleted the add-psbt-utils branch October 3, 2022 13:04
@notmandatory notmandatory mentioned this pull request Oct 19, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add ability to combine PSBTs
2 participants