Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uniffi-rs to 0.20.0 #203

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 4, 2022

This PR bumps the uniffi-rs library to 0.20.0

Notes to the reviewers

This neatly brings in the PR that fixes the bug with Swift keywords and brings us in line with the latest uniffi-rs version.

Changelog notice

- Update uniffi-rs to latest version 0.20.0 [#203]

[#203](https://github.com/bitcoindevkit/bdk-ffi/pull/203)

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@@ -6,5 +6,5 @@ edition = "2021"
[dependencies]
anyhow = "=1.0.45" # remove after upgrading to next version of uniffi
structopt = "0.3"
uniffi_bindgen = "0.19.5"
uniffi_bindgen = "=0.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also doesn't need to be pinned:

Suggested change
uniffi_bindgen = "=0.20.0"
uniffi_bindgen = "0.20.0"

@notmandatory notmandatory mentioned this pull request Oct 17, 2022
3 tasks
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 10fa276

@thunderbiscuit thunderbiscuit merged commit 10fa276 into bitcoindevkit:master Oct 17, 2022
@thunderbiscuit thunderbiscuit deleted the update-uniffi-rs branch October 17, 2022 20:17
@notmandatory notmandatory mentioned this pull request Oct 19, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants