Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare libraries for 0.26.0 release #290

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Jan 10, 2023

Description

This PR reflects the changes required to bump all libraries to their new release version.

I ran all tests and looked at examples, as well as updated the API docs for Kotlin, which did not include docs and samples for the new descriptor templates (that was my fault they should have been in PR #260 😅).

Notes to the reviewers

It's a lot of small stuff all over the place, let me know if I forgot anything.

The reason the tests passed in #288 is that we don't run the Python tests in the CI, nor the Swift ones, nor the Android ones! cc #291 and #282.

Changelog notice

There is not changelog notice for this PR.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit thunderbiscuit self-assigned this Jan 10, 2023
@thunderbiscuit thunderbiscuit added this to the Release 0.26.0 milestone Jan 10, 2023
@thunderbiscuit thunderbiscuit changed the title Update libraries for 0.26.0 release Prepare libraries for 0.26.0 release Jan 10, 2023
@thunderbiscuit thunderbiscuit force-pushed the update-libraries-for-026 branch 3 times, most recently from 620deb3 to c806f61 Compare January 10, 2023 19:44
@thunderbiscuit thunderbiscuit force-pushed the update-libraries-for-026 branch from c806f61 to 5f7d8a9 Compare January 10, 2023 21:15
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 5f7d8a9

I also verified on my system that android, jvm, and swift tests run.

@thunderbiscuit thunderbiscuit merged commit 5f7d8a9 into bitcoindevkit:master Jan 11, 2023
@thunderbiscuit thunderbiscuit deleted the update-libraries-for-026 branch November 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants