This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Split libraries into independent Gradle projects #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
split-libs
branch
from
2b3d29d to
4646917
Compare
|
Question for you @notmandatory: do you think the license files should be added to each of the directories? It feels that way to me, just so there is no mistaking it (even though it's sort of obvious). |
thunderbiscuit
force-pushed
the
split-libs
branch
3 times, most recently
from
414bb98 to
5450c08
Compare
bdk-jvm/plugins/README.md
Outdated
| @@ -0,0 +1,16 @@ | |||
| # Readme | |||
| The purpose of this directory is to host the Gradle plugin that add tasks for building the native binaries required by bdk-jvm, and building the language bindings files. | |||
There was a problem hiding this comment.
language nit
Suggested change
| The purpose of this directory is to host the Gradle plugin that add tasks for building the native binaries required by bdk-jvm, and building the language bindings files. | |
| The purpose of this directory is to host the Gradle plugin that adds tasks for building the native binaries required by bdk-jvm, and building the language bindings files. |
notmandatory
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
ACK 5450c08
I found one very small language nit.. but other than that looks good. I locally tested the android and jvm build and test maven tasks on my Mac M1.
|
Looks like you also may need to do a rebase. |
thunderbiscuit
force-pushed
the
split-libs
branch
from
5450c08 to
d603932
Compare
This was referenced Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the repository into two directories, each containing separate libraries as completely independent Gradle builds/projects.
Note that in order to be really careful I fixed the CI publishing workflow but brought it back to simply publishing to the staging repository (it's easy to make a typo and send the compiled binaries to the wrong directory) so that we can check them and see that everything is in the right place before publishing if we trigger the workflow and everything works well we can just make a quick fix that does the full publishing and merge that on the day of the release.
Notes to the reviewers
This is a big refactor so I want to make sure I think of everything:
Checklists