Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of check_wallet_descriptor #1557

Closed
ValuedMammal opened this issue Aug 14, 2024 · 0 comments · Fixed by #1597
Closed

Inconsistent use of check_wallet_descriptor #1557

ValuedMammal opened this issue Aug 14, 2024 · 0 comments · Fixed by #1597
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ValuedMammal
Copy link
Contributor

After #1533 we fail to call check_wallet_descriptor in all arms of a match block during load, but this was correct in v1.0.0-beta.1. Also, we apparently never apply the check during new wallet creation.

// parameters must match
Some(make_desc) => {
let (exp_desc, keymap) =
make_desc(&secp, network).map_err(LoadError::Descriptor)?;
if desc.descriptor_id() != exp_desc.descriptor_id() {
return Err(LoadError::Mismatch(LoadMismatch::Descriptor {
keychain: KeychainKind::Internal,
loaded: Some(desc),
expected: Some(exp_desc),
}));
}

@ValuedMammal ValuedMammal added the bug Something isn't working label Aug 14, 2024
@notmandatory notmandatory added this to BDK Aug 14, 2024
@notmandatory notmandatory moved this to Todo in BDK Aug 14, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 14, 2024
@ValuedMammal ValuedMammal self-assigned this Aug 29, 2024
@notmandatory notmandatory moved this from Todo to Needs Review in BDK Sep 9, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants