Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): do check_wallet_descriptor when creating and loading #1597

Merged

Conversation

ValuedMammal
Copy link
Contributor

Do check_wallet_descriptor for both external and internal descriptors when creating a wallet, and as a defensive measure also perform the check on the descriptors loaded from a changeset.

fixes #1557

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Sep 9, 2024
@ValuedMammal ValuedMammal added this to the 1.0.0-beta milestone Sep 9, 2024
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5aecf4d

@notmandatory notmandatory merged commit a4b4946 into bitcoindevkit:master Sep 11, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the fix/wallet-check-descriptor branch September 11, 2024 20:24
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Inconsistent use of check_wallet_descriptor
2 participants