-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stuff from crates/chain/tests/common
to bdk_testenv
and make them publicly-accessible
#1602
Comments
evanlinjin
added
new feature
New feature or request
good first issue
Good for newcomers
tests
labels
Sep 12, 2024
evanlinjin
changed the title
Move stuff from
Move stuff from Sep 12, 2024
crates/chain/tests/common
to bdk_testenv
and make them publicly-accessablecrates/chain/tests/common
to bdk_testenv
and make them publicly-accessible
4 tasks
@evanlinjin I would like to work on this issue. |
@tvpeter all yours! |
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 14, 2024
- add `tx_utils` to house all transaction utilities moved from `crates/chain/test/common` - deleted all moved macros and functions in `crates/chain/test/common/mod` - add `bitcoin` crate to `testenv` crate - add `tx_utils` mod to lib in testenv [Issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 14, 2024
- import testenv crate in chain crate - replace all macros and fns in the following tests with import from testenv crate - tests/test_indexed_tx_graph - tests/test_keychain_txout_index - tests/test_local_chain - tests/test_tx_graph - tests/test_tx_graph_conflicts [issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 14, 2024
- import testenv crate - delete common module and import `block_id` from testenv crate [issue: bitcoindevkit#1602]
Open
8 tasks
@evanlinjin, can you please review the PR here. I can't tag you there because the workflows require approval from a maintainer. Thank you. |
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 15, 2024
- add `tx_utils` to house all transaction utilities moved from `crates/chain/test/common` - deleted all moved macros and functions in `crates/chain/test/common/mod` - add `bitcoin` crate to `testenv` crate - add `tx_utils` mod to lib in testenv [Issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 15, 2024
- import testenv crate in chain crate - replace all macros and fns in the following tests with import from testenv crate - tests/test_indexed_tx_graph - tests/test_keychain_txout_index - tests/test_local_chain - tests/test_tx_graph - tests/test_tx_graph_conflicts [issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 15, 2024
- import testenv crate - delete common module and import `block_id` from testenv crate [issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 16, 2024
replace external crate `bitcoin` with re-exported `bdk_chain::bitcoin` [Ticket: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 16, 2024
- add `tx_utils` to house all transaction utilities moved from `crates/chain/test/common` - deleted all moved macros and functions in `crates/chain/test/common/mod` - add `bitcoin` crate to `testenv` crate - add `tx_utils` mod to lib in testenv [Issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 16, 2024
- import testenv crate in chain crate - replace all macros and fns in the following tests with import from testenv crate - tests/test_indexed_tx_graph - tests/test_keychain_txout_index - tests/test_local_chain - tests/test_tx_graph - tests/test_tx_graph_conflicts [issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 16, 2024
- import testenv crate - delete common module and import `block_id` from testenv crate [issue: bitcoindevkit#1602]
tvpeter
added a commit
to tvpeter/bdk
that referenced
this issue
Sep 16, 2024
replace external crate `bitcoin` with re-exported `bdk_chain::bitcoin` [Ticket: bitcoindevkit#1602]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement
These macros, fake-tx-construction-tools are helpful in other crates too. Let's move them to
bdk_testenv
and make them publicly available.Use case
Better test tooling.
The text was updated successfully, but these errors were encountered: