Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing bdk_core README.md and remove specific bdk_chain dev version #1573

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 25, 2024

Add the missing README.md file for the bdk_core crate. This is required to publish to crates.io.

Also had to removed fixed bdk_chain version from bdk_core dev dependencies to prevent missing dependency when publishing bdk_core before publishing new version of bdk_chain.

@notmandatory notmandatory self-assigned this Aug 25, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 25, 2024
@notmandatory notmandatory changed the title fix: add missing bdk_core README.md chore: add missing bdk_core README.md and remove specific bdk_chain dev dependency version Aug 25, 2024
@notmandatory notmandatory changed the title chore: add missing bdk_core README.md and remove specific bdk_chain dev dependency version chore: add missing bdk_core README.md and remove specific bdk_chain dev version Aug 25, 2024
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 48b6a66

@notmandatory notmandatory merged commit 775e4ae into bitcoindevkit:master Aug 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants