Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(wallet): Add docs to explain the lookahead #1596

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ValuedMammal
Copy link
Contributor

Adds clarifying language to CreateParams and LoadParams regarding the lookahead parameter. Commit 028f687 also includes some minor documentation fixes.

If anyone is aware of any more documentation flaws that need attention I'm happy to add them here.

cc #1540

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Sep 9, 2024
@ValuedMammal ValuedMammal added this to the 1.0.0-beta milestone Sep 9, 2024
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 028f687

crates/wallet/src/wallet/params.rs Show resolved Hide resolved
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 028f687

@LagginTimes
Copy link
Contributor

ACK 028f687

@ValuedMammal ValuedMammal merged commit 2cf46a2 into bitcoindevkit:master Sep 16, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the doc/miscellaneous branch September 16, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants