Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #1599

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: typos #1599

merged 1 commit into from
Sep 11, 2024

Conversation

storopoli
Copy link
Contributor

Description

more typos caught up during rebasing of #1320.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@storopoli storopoli mentioned this pull request Sep 10, 2024
Open
8 tasks
oleonardolima
oleonardolima approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bc83e41

@LagginTimes
Copy link
Contributor

ACK bc83e41

thunderbiscuit
thunderbiscuit approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bc83e41.

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Sep 11, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Sep 11, 2024
@notmandatory notmandatory merged commit 532f906 into bitcoindevkit:master Sep 11, 2024
21 checks passed
@storopoli storopoli deleted the fix-more-typos branch September 11, 2024 16:57
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@storopoli @LagginTimes @oleonardolima @thunderbiscuit @notmandatory