Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): calling CheckPoint::insert with existing block must succeed #1601

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix(core): calling CheckPoint::insert with existing block must succeed #1601

merged 3 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. fix(core): calling CheckPoint::insert with existing block must succeed 

    Previously, we were panicking when the caller tried to insert a block at
height 0. However, this should succeed if the block hash does not
change.
    @evanlinjin
    evanlinjin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2970b83 View commit details
    Browse the repository at this point in the history

  2. doc(core): document panic for CheckPoint::insert

    @ValuedMammal
    ValuedMammal committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e6aeaea View commit details
    Browse the repository at this point in the history

  3. test: fix off-by-one in checkpoint_insert_existing

    @ValuedMammal
    ValuedMammal committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3ae9ecb View commit details
    Browse the repository at this point in the history