rm ecdsa, switch out ECPair secp256k1 impl. #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
force-pushed
the
tinyec
branch
2 times, most recently
from
2666b68
to
efd867f
Compare
This was referenced May 15, 2018
Closed
dcousens
force-pushed
the
tinyec
branch
4 times, most recently
from
07e5b2f
to
f33f20d
Compare
|
Rebased on #1085 |
dcousens
force-pushed
the
tinyec
branch
6 times, most recently
from
1307a37
to
c2662dd
Compare
junderw
approved these changes
May 30, 2018
woodser
reviewed
Jun 9, 2018
|
|
||
| assert.strictEqual(keyPair.d.toString(), f.d) | ||
| assert.strictEqual(keyPair.privateKey.toString('hex'), f.d) |
There was a problem hiding this comment.
The hex will not be padded so it may contain fewer than 64 characters for some private keys, such as this LTC private key: T34MuTEaRxt3kj6dn2MMHbvSPQHrsBjKrdz6WtwrLe1KzCzYkMup.
Shouldn't it be padded to conform to 64 characters?
There was a problem hiding this comment.
@woodser .privateKey is enforced to be 256-bits, or 32-bytes in .length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1045, #1049