Improved PID documentation #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gemenerik
commented
Jun 26, 2024
gemenerik
commented
- Improved the explanation of the cascaded PID controller structure.
- Clarified the role of each control level (position, velocity, attitude, attitude rate) in the PID hierarchy.
- Detailed how different setpoints (not just position) activate corresponding PID controllers.
- Clarified that the position controller does not generate attitude setpoints directly.
- Clarified the function of the attitude rate controller, specifying that its output is not directly thrust.
- Documented the PID modification introduced in PID should avoid derivative kick #1336 to prevent derivative kick.
- Introduced a code comment regarding the prevention of derivative kick.
tobbeanton
reviewed
Jun 26, 2024
- Improved the explanation of the cascaded PID controller structure. - Clarified the role of each control level (position, velocity, attitude, attitude rate) in the PID hierarchy. - Detailed how different setpoints (not just position) activate corresponding PID controllers. - Clarified that the position controller does not generate attitude setpoints directly. - Clarified the function of the attitude rate controller, specifying that its output is not directly thrust. - Documented the PID modification introduced in #1336 to prevent derivative kick. - Introduced a code comment regarding the prevention of derivative kick.
gemenerik
force-pushed
the
rik/derivative_kick_documentation
branch
from
8d9af53
to
53f8383
Compare
knmcguire
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.