Expose production test rpm values as params #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToveRumar
force-pushed
the
toverumar/update_rpm_limits
branch
4 times, most recently
from
3e033d0
to
506c3ad
Compare
ToveRumar
changed the title
This will make it possible to fetch individual motor results using the lib in production We can now scrap the result checking inside the FW and check the RPM in the production test instead
ToveRumar
force-pushed
the
toverumar/update_rpm_limits
branch
from
506c3ad
to
1924968
Compare
evoggy
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove limit for RPM self test and expose result as params instead