[sdk] Include 3XX http responses in success results (#25)

* [sdk] Include 3XX http responses in success results * [sdk] Include 3XX http responses in success results
bitdriftlabs · Sep 5, 2024 · cb0bbe2 · cb0bbe2
1 parent a5e8d0f
commit cb0bbe2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.../capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt b/.../capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/CaptureOkHttpEventListener.kt
@@ -223,8 +223,7 @@ internal class CaptureOkHttpEventListener internal constructor(
 
         // Do not use OkHttp's `isSuccess` logic for determining whether a given response is
         // successful or not to keep iOS and Android implementation in sync.
-        val isSuccess = (statusCode in 200..<300) ||
-            statusCode == 304 // "Not Modified" status code
+        val isSuccess = (statusCode in 200..<400)
 
         // Capture response URL attributes in case there was a redirect and attributes such as host,
         // path, and query have different values for the original request and the response.
@@ -238,7 +237,7 @@ internal class CaptureOkHttpEventListener internal constructor(
             } else {
                 HttpResponse.HttpResult.FAILURE
             },
-            statusCode = response.code,
+            statusCode = statusCode,
             headers = response.headers.toMap(),
         )
 

diff --git a/platform/swift/source/network/native/HTTPStatus.swift b/platform/swift/source/network/native/HTTPStatus.swift
@@ -57,7 +57,6 @@ struct HTTPStatus {
 
 private extension Int {
     var isSuccess: Bool {
-        return (200..<300).contains(self)
-            || self == 304 // "Not Modified" status code
+        return (200..<400).contains(self)
     }
 }