Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk][andr] Don't use PowerManager if not available #35

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[sdk][andr] Don't use PowerManager if not available #35

merged 2 commits into from
Sep 10, 2024

Conversation

murki
Copy link
Contributor

@murki murki commented Sep 10, 2024 •
edited
Loading

Customers have reported encountering certain devices (particularly the Caterpillar S48C phone) where context.getSystemService(Context.POWER_SERVICE) would be null causing our Logger.configure() method to throw.

Augustyniak
Augustyniak approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Augustyniak Augustyniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment for why we keep it as optional (power manager)

@murki murki enabled auto-merge (squash) September 10, 2024 19:33
@murki murki merged commit d888daa into main Sep 10, 2024
15 checks passed
@murki murki deleted the murki/ignore-null-service branch September 10, 2024 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Augustyniak Augustyniak Augustyniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murki @Augustyniak