Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle repeated writeTo calls in okhttp network #78

Merged
merged 5 commits into from
Oct 11, 2024
Merged

handle repeated writeTo calls in okhttp network #78

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f7a63c
handle repeated writeTo calls
snowp Oct 11, 2024
1fa5b56
fmt
snowp Oct 11, 2024
fd526f3
suppress lint
snowp Oct 11, 2024
65401e9
more suppressing
snowp Oct 11, 2024
54f25e6
lint annotations
snowp Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/OkHttpNetwork.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,15 @@ internal class PipeDuplexRequestBody(
override fun contentType() = contentType

override fun writeTo(sink: BufferedSink) {
pipe.fold(sink)
// If this gets called more than once (e.g. due to an automatically injected
// interceptor), we want to ignore the second call. This is because the pipe
// is a one-shot object, and we don't want to try to write to it again.
//
// From the perspective of the caller this will look like the request was empty.
try {
pipe.fold(sink)
} catch (e: Throwable) {
}
}

override fun isDuplex() = true
Expand Down
Loading