app update: fix ootb app update event #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augustyniak
commented
Aug 27, 2024
| let Some(previous_app_version) = self.store.get(&APP_VERSION_KEY) else { | ||
| // Initialize app version change detection logic by setting the current app version, | ||
| // making it available for comparison after a user updates their app. | ||
| self.store.set(&APP_VERSION_KEY, app_version); |
There was a problem hiding this comment.
This is the clue of the change
snowp
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix out-of-the-box "App Update" event for apps that haven't emitted any App Update event yet. In their case we ended up calling
has_changedon every app open and each time the return value from the method wasfalsewhich prevented the emission of the app update event.After the changes from this PR, we bootstrap the app version change detection logic while calling
has_changedby storing current app version in the store so that it's available for the comparison on next app open.