filters: add extra logging, fix filters config updates #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Augustyniak
commented
Sep 9, 2024
Augustyniak
commented
- Fix propagation of filters configuration updates
- add extra logging for improved debugability.
Augustyniak
commented
Sep 9, 2024
| @@ -164,6 +164,7 @@ impl ProcessingPipeline { | |||
| self.buffer_selector = config.buffer_selector; | |||
| self.buffer_producers = config.buffer_producers; | |||
| self.tail_configs = config.tail_configs; | |||
| self.filter_chain = config.filter_chain; | |||
There was a problem hiding this comment.
this was missing, it made is so that filters config update that happened while SDK was up and running were effectively invisible to the SDK until the next relaunch.
murki
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.