Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize GitHub workflow for release build #322

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Feb 22, 2024

This PR optimizes GitHub Actions Workflow for release build


Basic changes:

  • Prevents electron-builder config modifying when setting repo owner in GH Actions Workflow, adds ability to set repo owner from env var into electron-builder config. It's more secure and flexible for beta releases as well
  • Skips GH Actions Workflow for tests report if the test runner is canceled
  • Launchs GH Actions Workflow for E2E tests when the build is successful
  • Fixes random failed to install npm package from git in Docker. Related to this issue: [BUG] Failed to install npm package from git in docker since v6.11.0  npm/cli#624

Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit dff36aa into bitfinexcom:staging Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants