Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPROD 381 Stable structs get corrupted after upgrade #157

Merged
merged 1 commit into from
Jun 21, 2023
Merged

EPROD 381 Stable structs get corrupted after upgrade #157

merged 1 commit into from
Jun 21, 2023

Conversation

veeso
Copy link
Member

@veeso veeso commented Jun 16, 2023 •
edited
Loading

Run integration test for stable-structures with

export WASMS_DIR="../target/wasm32-unknown-unknown/release/"
dfx build dummy_canister && cargo test -p ic-stable-structures@0.3.53 --features state-machine

@veeso veeso force-pushed the EPROD-381-investigate-the-evmc-canister-upgrade-problems branch from 98b4bac to 522c9fc Compare June 19, 2023 14:08
@veeso veeso changed the title EPROD 381 investigate the evmc canister upgrade problems EPROD 381 Stable structs get corrupted after upgrade Jun 19, 2023
@veeso veeso marked this pull request as ready for review June 19, 2023 14:40
@veeso veeso marked this pull request as draft June 20, 2023 07:25
@veeso veeso marked this pull request as ready for review June 20, 2023 08:18
@veeso veeso requested review from ufoscout, F3kilo and GraDKh June 20, 2023 08:18
ufoscout
ufoscout requested changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@ufoscout ufoscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests to be integrated with the CI

@veeso veeso force-pushed the EPROD-381-investigate-the-evmc-canister-upgrade-problems branch from daa2d0e to 061bf0b Compare June 21, 2023 09:08
@veeso veeso requested a review from ufoscout June 21, 2023 09:09
@veeso veeso force-pushed the EPROD-381-investigate-the-evmc-canister-upgrade-problems branch from 061bf0b to 1b55fb8 Compare June 21, 2023 13:16
@veeso veeso merged commit d435d1b into main Jun 21, 2023
@veeso veeso deleted the EPROD-381-investigate-the-evmc-canister-upgrade-problems branch June 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GraDKh GraDKh GraDKh approved these changes

@ufoscout ufoscout ufoscout approved these changes

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veeso @ufoscout @GraDKh