Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the redundant BitCircularTimePickerDialMode enum in the BitCircularTimePicker #7411

Closed
Cyrus-Sushiant opened this issue Apr 26, 2024 · 0 comments · Fixed by #7412
Closed

Remove the redundant BitCircularTimePickerDialMode enum in the BitCircularTimePicker #7411

Cyrus-Sushiant opened this issue Apr 26, 2024 · 0 comments · Fixed by #7412
Assignees
@Cyrus-Sushiant
Labels
area / BlazorUI
Milestone
054 - Apr 2024 - 2

Comments

@Cyrus-Sushiant
Copy link
Member

The BitCircularTimePicker component currently uses an enum, BitCircularTimePickerDialMode, to switch between hour and minute modes. This approach can be simplified by using a boolean value instead.
@msynk msynk changed the title Refactor BitCircularTimePicker to use boolean instead of enum Remove the redundant BitCircularTimePickerDialMode enum in the BitCircularTimePicker Apr 27, 2024
@msynk msynk added this to the 054 - Apr 2024 - 2 milestone Apr 27, 2024
@msynk msynk moved this to In Progress in bit platform Apr 27, 2024
@Cyrus-Sushiant Cyrus-Sushiant mentioned this issue Apr 27, 2024
Merged
msynk pushed a commit that referenced this issue Apr 29, 2024
@Cyrus-Sushiant
feat(blazorui): remove BitCircularTimePickerDialMode enum in BitCircu…
f957b31 
…larTimePicker #7411 (#7412)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyrus-Sushiant Cyrus-Sushiant

Labels
area / BlazorUI
Projects
bit platform
Archived in project
Milestone
054 - Apr 2024 - 2
2 participants
@msynk @Cyrus-Sushiant