Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing System.Net.Http.Json using in the generated code of the HttpClient source generator #7420

Closed
ysmoradi opened this issue May 1, 2024 · 0 comments · Fixed by #7372
Closed

Missing System.Net.Http.Json using in the generated code of the HttpClient source generator #7420

ysmoradi opened this issue May 1, 2024 · 0 comments · Fixed by #7372
Assignees
@ysmoradi
Labels
area / source generators
Milestone
055 - May 2024 - 1

Comments

@ysmoradi
Copy link
Member

ysmoradi commented May 1, 2024 •
edited by msynk
Loading

bit source generator needs the following namespaces:

System.Text.Json
System.Net.Http.Json
System.Web

currently, the System.Net.Http.Json namespace is missing from the usings of the generated code, and it only relies on the consumer's project to have these namespaces in its global usings, which is not a proper assumption.
So it is necessary to add these namespaces to the generated code explicitly.
@ysmoradi ysmoradi added this to the 055 - May 2024 - 1 milestone May 1, 2024
@ysmoradi ysmoradi self-assigned this May 1, 2024
@ysmoradi ysmoradi moved this to In Progress in bit platform May 1, 2024
@ysmoradi ysmoradi mentioned this issue May 1, 2024
Merged
@msynk msynk changed the title Http client source generator relies on System.Net.Http.Json but doesn't explicitly uses that namespace Missing System.Net.Http.Json using in the generated code of the HttpClient source generator May 1, 2024
msynk pushed a commit that referenced this issue May 1, 2024
@jpmchia
feat(source generators): add missing using in generated code of HttpC…
18467f4 
…lient source generator #7420 (#7372)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysmoradi ysmoradi

Labels
area / source generators
Projects
bit platform
Archived in project
Milestone
055 - May 2024 - 1
1 participant
@ysmoradi