Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Culture parameter of the BitDateRangePicker is missing some change handling #8370

Closed
Cyrus-Sushiant opened this issue Aug 21, 2024 · 0 comments · Fixed by #8371
Closed

The Culture parameter of the BitDateRangePicker is missing some change handling #8370

Cyrus-Sushiant opened this issue Aug 21, 2024 · 0 comments · Fixed by #8371
Assignees
@Cyrus-Sushiant
Labels
area / BlazorUI
Milestone
063 - Aug 2024 - 2

Comments

@Cyrus-Sushiant
Copy link
Member

Currently, the BitDateRangePicker component does not reset its internal variables when the Culture parameter is set. This can lead to inconsistencies in the displayed date formats and other culture-specific settings.

Add the [CallOnSet(nameof(HandleParameterChanges))] attribute to the Culture parameter in the BitDateRangePicker component. This will ensure that the necessary variables are reset whenever the Culture parameter is updated.
@Cyrus-Sushiant Cyrus-Sushiant mentioned this issue Aug 21, 2024
Merged
@msynk msynk changed the title Add CallOnSet attribute on Culture parameter in BitDateRangePicker The Culture parameter of the BitDateRangePicker is missing some change handling Aug 21, 2024
@msynk msynk added this to the 063 - Aug 2024 - 2 milestone Aug 21, 2024
@msynk msynk moved this to In Progress in bit platform Aug 21, 2024
msynk pushed a commit that referenced this issue Aug 21, 2024
@Cyrus-Sushiant
feat(blazorui): add CallOnSet attribute on Culture parameter in BitDa…
ab5feb0 
…teRangePicker #8370 (#8371)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyrus-Sushiant Cyrus-Sushiant

Labels
area / BlazorUI
Projects
bit platform
Status: Done
Milestone
063 - Aug 2024 - 2
2 participants
@msynk @Cyrus-Sushiant