Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Max and Content settings in OnParametersSetAsync of BitBadge component #8787

Closed
Cyrus-Sushiant opened this issue Sep 28, 2024 · 0 comments · Fixed by #8805
Closed

Incorrect Max and Content settings in OnParametersSetAsync of BitBadge component #8787

Cyrus-Sushiant opened this issue Sep 28, 2024 · 0 comments · Fixed by #8805
Assignees
@Cyrus-Sushiant
Labels
area / BlazorUI
Milestone
066 - Oct 2024 - 1

Comments

@Cyrus-Sushiant
Copy link
Member

Cyrus-Sushiant commented Sep 28, 2024 •
edited
Loading

In the BitBadge component, the Max and Content settings are currently handled within the OnParametersSetAsync lifecycle method.
To correct this issue, we should remove the overrides of the OnParametersSetAsync method and instead utilize the [CallOnSet] attribute for the Max and Content parameters. This will ensure that changes are handled more efficiently and synchronously, avoiding the overhead and potential issues associated with OnParametersSetAsync.
@msynk msynk added this to the 065 - Sep 2024 - 2 milestone Sep 28, 2024
@msynk msynk moved this to In Progress in bit platform Sep 28, 2024
@Cyrus-Sushiant Cyrus-Sushiant changed the title Incorrect Max and Content settings in the OnParametersSetAsync lifecycle method of the BitBadge component Incorrect Max and Content settings in OnParametersSetAsync of BitBadge component Oct 1, 2024
@Cyrus-Sushiant Cyrus-Sushiant mentioned this issue Oct 1, 2024
Merged
msynk pushed a commit that referenced this issue Oct 1, 2024
@Cyrus-Sushiant
feat(blazorui): refactor BitBadge component to use CallOnSet attribute …
adf5934 
…#8787 (#8805)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyrus-Sushiant Cyrus-Sushiant

Labels
area / BlazorUI
Projects
bit platform
Status: Done
Milestone
066 - Oct 2024 - 1
Development

Successfully merging a pull request may close this issue.

Refactor BitBadge component to use CallOnSet attribute (#8787) Cyrus-Sushiant/bitplatform
2 participants
@msynk @Cyrus-Sushiant