Replace Down icons with Up in BlazorUI (#9234) #9235
Conversation
WalkthroughThe pull request introduces cosmetic changes to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DatePicker/BitDatePicker.razor (1)
176-176: LGTM! Icon changes align with requirements.The changes correctly implement the requirement to replace Down icons with Up icons by using CSS rotation. This approach is clean and maintains visual consistency.
Consider creating a dedicated CSS class for rotated navigation icons to avoid repetition. For example:
- class="bit-icon bit-icon--Up bit-ico-r180 @Classes?.NextMonthNavIcon" + class="bit-icon bit-icon--Up bit-nav-icon-down @Classes?.NextMonthNavIcon"Then define in CSS:
.bit-nav-icon-down { transform: rotate(180deg); }This would make the rotation intent clearer and reduce repetition across the codebase.
Also applies to: 349-349, 467-467
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Calendar/BitCalendar.razor(3 hunks)src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DatePicker/BitDatePicker.razor(3 hunks)src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DateRangePicker/BitDateRangePicker.razor(3 hunks)
🔇 Additional comments (2)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Calendar/BitCalendar.razor (1)
93-93: Icon changes look consistent with requirements.
The changes correctly implement the replacement of Down icons with rotated Up icons using the bit-ico-r180 CSS class, which aligns with the PR objectives.
Let's verify the existence of the required CSS class:
Also applies to: 250-250, 366-366
✅ Verification successful
Let me check the implementation of the CSS class to ensure it provides the expected rotation:
Icon rotation implementation is correct and properly defined
The CSS class bit-ico-r180 is properly defined in general.scss with the correct transform: rotate(180deg) implementation, which will achieve the desired 180-degree rotation of the Up icons as required. The changes are consistent across all instances in the calendar component.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the bit-ico-r180 CSS class is defined in the stylesheets
# Expected: Find CSS class definition for bit-ico-r180
# Search for the CSS class definition
rg -t css "\.bit-ico-r180"
# Search for any SCSS/SASS files that might define this class
fd -e scss -e sass | xargs rg "\.bit-ico-r180"
Length of output: 201
Script:
#!/bin/bash
# Get the implementation of bit-ico-r180 class with context
rg -A 3 "\.bit-ico-r180" src/BlazorUI/Bit.BlazorUI/Styles/general.scss
Length of output: 122
src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DateRangePicker/BitDateRangePicker.razor (1)
173-173: LGTM! Icon changes are consistent with requirements.
The changes correctly implement the icon replacement requirement by:
- Replacing
bit-icon--Downwithbit-icon--Up - Adding
bit-ico-r180class for 180-degree rotation
Let's verify that all Down icons have been replaced:
Also applies to: 347-347, 465-465
✅ Verification successful
After reviewing the file content, I can now generate the final response:
All Down icons have been correctly replaced with Up icons + rotation
The verification confirms that:
- Line 173: Uses
bit-icon--Up bit-ico-r180for next month navigation - Line 347: Uses
bit-icon--Up bit-ico-r180for next year navigation - Line 465: Uses
bit-icon--Up bit-ico-r180for next year range navigation - No instances of
bit-icon--Downremain in the file
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining Down icons in the file
# Expect: No matches as all Down icons should have been replaced
rg --no-filename "bit-icon--Down" "src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DateRangePicker/BitDateRangePicker.razor"
Length of output: 127
Script:
#!/bin/bash
# Let's verify the file content to ensure all icon changes
cat "src/BlazorUI/Bit.BlazorUI/Components/Inputs/_Pickers/DateRangePicker/BitDateRangePicker.razor"
Length of output: 51738
msynk
changed the title
This closes #9234
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
Style
Tests
Chores
Revert