Add InitialSelectedItems parameter to BitDorpdown (#9364) #9381
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve the introduction of a new public parameter, Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (1)
787-814: Consider adding validation and handling edge cases.While the initialization logic works correctly, there are a few potential improvements to consider:
- The
InitialSelectedItemsparameter is only processed during initialization. Consider documenting this limitation or implementing support for runtime changes.- Add validation for the items in
InitialSelectedItemsto ensure they are valid before selection.- Add null check before calling
InitialSelectedItems.First()to prevent potential null reference exceptions.if (ItemsProvider is not null && (InitialSelectedItems?.Any() ?? false)) { + // Validate items before selection + var validItems = InitialSelectedItems.Where(item => + item != null && GetItemType(item) == BitDropdownItemType.Normal && GetIsEnabled(item)); + if (MultiSelect) { - foreach (var item in InitialSelectedItems) + foreach (var item in validItems) { _selectedItems.Add(item); } } else { - _selectedItems.Add(InitialSelectedItems.First()); + var firstValidItem = validItems.FirstOrDefault(); + if (firstValidItem != null) + { + _selectedItems.Add(firstValidItem); + } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs(3 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs(1 hunks)
🔇 Additional comments (3)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs (1)
134-139: LGTM! Parameter documentation is clear and complete.
The new parameter InitialSelectedItems is well documented with appropriate type, default value, and a clear description of its purpose.
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (2)
129-132: LGTM! Parameter declaration is well documented.
The new parameter InitialSelectedItems is properly declared with clear XML documentation explaining its purpose.
1172-1173: LGTM! State updates are properly handled.
The changes ensure that selected items are updated and the UI is refreshed after fetching new data. The use of InvokeAsync for StateHasChanged is correct as this is running in response to an async operation.
This closes #9364
Summary by CodeRabbit
InitialSelectedItemsfor theBitDropdowncomponent, allowing users to specify initial selections when using an item provider.BitDropdownDemocomponent to support the newInitialSelectedItemsparameter, improving its configurability.These updates improve the user experience by allowing better management of initial dropdown selections.