Fix issues of FixedColor and IconOnly parameters in BitButton (#9382)

[msynk]

closes #9382

Summary by CodeRabbit

• New Features

  • Introduced a FixedColor parameter for the BitButton, allowing a constant foreground color regardless of hover states.
  • Added new examples showcasing the BitButton with fixed colors, loading states, and custom styles.

• Bug Fixes

  • Streamlined the "FullWidth" example by removing unnecessary markup for improved clarity.

• Documentation

  • Updated titles and reorganized examples in the BitButtonDemo to enhance usability and clarity of the component's features.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the BitButton component within the Blazor UI framework. Key updates include the reorganization of SCSS classes for button styling and the introduction of a new FixedColor parameter in the BitButtonDemo file, allowing buttons to maintain a constant foreground color. Additionally, new examples demonstrating various button configurations and properties have been added to enhance documentation and usability. Overall, these changes aim to improve the functionality and presentation of the BitButton component.

Changes

File	Change Summary
src/BlazorUI/Bit.BlazorUI/Components/Buttons/BitButton/BitButton.scss	Reorganized .bit-btn-ntx and .bit-btn-fxc classes, maintaining their properties but changing their order.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor	Added FixedColor parameter, updated example titles, and streamlined markup for "FullWidth" example.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor.samples.cs	Added new examples for FixedColor, loading states, and RTL support; introduced new fields for loading states.

Assessment against linked issues

Objective	Addressed	Explanation
The BitButton FixedColor stopped working (##9382)	✅

🐰 In the meadow, bright buttons gleam,
With colors fixed, they dance and beam.
Styles rearranged, examples anew,
For every click, a vibrant hue!
Hopping along, we celebrate,
The BitButton magic, oh, isn’t it great? 🌈✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor.samples.cs (1)

314-325: LGTM! Consider adding hover state description.

The example effectively demonstrates the FixedColor parameter with different variants. The code is well-structured and follows consistent formatting.

Consider adding a comment in the example to explicitly show how the hover state differs with and without FixedColor:

 <BitButton FixedColor IconOnly
           Size="BitSize.Large"
           Variant="BitVariant.Outline"
           IconName="@BitIconName.Emoji2"
-           Color="BitColor.TertiaryBackground" />
+           Color="BitColor.TertiaryBackground" /> @* Color remains TertiaryBackground on hover *@

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor (1)

379-393: LGTM! Consider enhancing the documentation.

The new FixedColor example is well-structured and effectively demonstrates the feature. The description clearly explains its purpose.

Consider adding a note about the use case or scenario where FixedColor would be most beneficial:

-            <div>FixedColor flag parameter makes the foreground color to be fixed regardless of its hovering state.</div>
+            <div>FixedColor flag parameter makes the foreground color to be fixed regardless of its hovering state. This is particularly useful for maintaining consistent color schemes in icon-only buttons or when specific brand colors need to be preserved.</div>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b98ca22 and 1e406a7.

📒 Files selected for processing (3)

• src/BlazorUI/Bit.BlazorUI/Components/Buttons/BitButton/BitButton.scss (1 hunks)
• src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor (3 hunks)
• src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor.samples.cs (4 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/BlazorUI/Bit.BlazorUI/Components/Buttons/BitButton/BitButton.scss

🔇 Additional comments (3)

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor.samples.cs (1)

Line range hint 326-490: LGTM! Example renumbering is consistent.

The renumbering of examples (15->16, 16->17, 17->18) has been done consistently while preserving the original content.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/BitButtonDemo.razor (2)

375-377: LGTM! Markup simplified.

The removal of unnecessary div wrapper improves code clarity while maintaining the same functionality.

---

Line range hint 397-511: LGTM! Example renumbering is consistent.

The example numbers have been updated consistently throughout the ComponentExampleBox components while preserving the original content.