Change black/Black -> deny/Deny; white/White -> allow/Allow

[dsafanyuk]

closes #241

[bithavoc]

@dsafanyuk great stuff, but I'm worried this is going to break typescript project where warnings are treated as errors. is there a way we can keep both for the 4.x series with warnings for typescript and then maybe drop in the 5x series?

[dsafanyuk]

@dsafanyuk great stuff, but I'm worried this is going to break typescript project where warnings are treated as errors. is there a way we can keep both for the 4.x series with warnings for typescript and then maybe drop in the 5x series?

So keep black/white list, while adding allow/deny list?

[dsafanyuk]

And i'm not that familiar with typescript, can you give me an example of what you're worried about!

(ps. this is my first OSS contribution, so please let me know if I'm following best practices!)

[bithavoc]

wow this is going to be harder than I thought, but yeah we can't break backward compatibility without a warning and the closes thing to a deprecation is the JSDoc for @deprecated which apparently only works if you have eslint enabled (?).

So I'm thinking the first step should be Updating the readme stating our something like "We no longer feel comfortable with the terms "whitelist" and "blacklist" and therefore these terms and configuration options are going away in the upcoming 5.x series, we prefer to use allowlist and denylist instead".

So for now we only rename all the private members such as req. _routeWhitelists and function variables such as requestAllowlist like you have it in your PR, and we update the Readme to introduce the new members in the documentation and also add comments to the typescript interfaces.

Thoughts?

[bithavoc]

@dsafanyuk, unfortunately, we're gonna have to come up with a new PR targetting the 5.x branch which still does not exists, see #247

Thank you, this PR really inspired me and highlighted some of the issues in the transition in order to address the situation with respect to both the black community and the users of this project.

[forivall]

@bithavoc typescript itself has support for @deprecated, you don't need eslint for it (it's a new feature tho)