Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility: find parent overlay element by css-selector #38

Closed
macjohnny opened this issue Jun 18, 2018 · 0 comments · Fixed by #39
Closed

Compatibility: find parent overlay element by css-selector #38

macjohnny opened this issue Jun 18, 2018 · 0 comments · Fixed by #39
Assignees
@macjohnny
Labels
feature New feature or request

Comments

@macjohnny
Copy link
Member

Find parent overlay element by css-selector instead of using .parentElement (mat-select-search.component.ts#L332)
in order to avoid incompatibility due to markup changes, e.g. in angular/components#11801
@macjohnny macjohnny added the feature New feature or request label Jun 18, 2018
@macjohnny macjohnny self-assigned this Jun 18, 2018
macjohnny added a commit that referenced this issue Jun 28, 2018
@macjohnny
#38: improve forward-compatibility
097b662
macjohnny added a commit that referenced this issue Jun 28, 2018
@macjohnny
#38: fix unit-test warnings
0dc0ece
macjohnny added a commit that referenced this issue Jun 28, 2018
@macjohnny
#38: prepare version 1.2.4
834cec9
@macjohnny macjohnny mentioned this issue Jun 28, 2018
Merged
macjohnny added a commit that referenced this issue Jun 28, 2018
@macjohnny
#38: user original class name
ae5d9e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macjohnny macjohnny

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/38 compatibility enhancement bithost-gmbh/ngx-mat-select-search
1 participant
@macjohnny