Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listIndentWidth argument to HtmlViewHelper. #239

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

marcharding
Copy link
Contributor

Introduces a listIndentWidth argument which is passed to TCPDF::setListIndentWidth.
This is needed because the indentation of lists cannot be overwritten with pure CSS.

@maechler
Copy link
Member

@marcharding Thank you very much for your contribution! It would be great if you could also add it to the TypoScript settings, similar to styleSheet. If you don't have time, I will do it as soon as I find the time.

html {
autoHyphenation =
styleSheet =
padding {
top = 0
right = 0
bottom = 2
left = 0
}
}

$this->registerArgument('styleSheet', 'string', 'The path to an external style sheet being used to style this HTML content.', false, $this->settings['html']['styleSheet']);

html.autoHyphenation :ref:`t3tsref:data-type-boolean` *See generalText*
html.styleSheet_ :ref:`t3tsref:data-type-string`
html.padding_ Array {top: 0, right: 0, bottom: 2, left: 0}

@marcharding
Copy link
Contributor Author

Sure, just added it, overlook that before...

Thanks for the Extension (super helpful!) and have a nice holiday season.

@maechler maechler self-assigned this Dec 27, 2023
Copy link
Member

@maechler maechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcharding Looks good to me, thank you very much!

@maechler maechler merged commit 117becb into bithost-gmbh:main Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants