fix: Remove the default connection close header (v2 branch) #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at https://nodejs.org/api/http.html#new-agentoptions This fixes node-fetch#1735 and likely replaces node-fetch#1473 The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. node-fetch@af21ae6 node-fetch@7f68577 This commit is backported to the v2 branch from node-fetch#1736 against v3.
dhedey
changed the title
This was referenced Jul 27, 2023
This comment was marked as resolved.
This comment was marked as resolved.
jimmywarting
approved these changes
Aug 18, 2023
|
🎉 This PR is included in version 2.6.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This has broken some tests we did with https://github.com/nock/nock 's NockBack feature where we expected the "connection: close" header to be sent. We've updated the tests and everything is fine. |
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced Sep 23, 2024
This was referenced Sep 25, 2024
This was referenced Sep 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #1736 fixing #1735 to the 2.x branch. Reasoning for why this is important is in this comment.
I believe this change is low-risk for applying against 2.x, for a few reasons:
Connection: Closewas ever needed. It appears to have always caused issues if trying to combine with keep-alive.Connection: Closeheader: https://nodejs.org/docs/latest-v4.x/api/http.html#http_http_globalagent. - there is a slim chance it might cause slight behaviour differences in terms of connection handling with some legacy web servers, but I believe it is unlikely to break anything and the risk is slim compared with the issue many people are encountering when not fixing the issue.Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at
https://nodejs.org/api/http.html#new-agentoptions
This fixes #1735 and likely replaces #1473
The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. af21ae6 7f68577
This commit is backported to the v2 branch from #1736 against v3.