Remove redis v2 engine due to the performance issue (#224)

We allowed to use DB as the secondary storage(Spanner) for increasing
the capacity of Redis, but we don't think it's a good propse after
benchmarking(about 1000 QPS for 2 Spanner instances). So we decided to
remove this experimental feature now.

Makefile

@@ -23,9 +23,7 @@ teardown:
 	@bash scripts/teardown.sh
 
 test:
-	- cd scripts/spanner && docker-compose up --force-recreate -d && cd ../..
 	@sh scripts/run-test.sh
-	- cd scripts/spanner && docker-compose down && cd ../..
 
 lint:
 	@rm -rf lint.log

config/config.go

@@ -85,16 +85,6 @@ type RedisConf struct {
 	MasterName       string
 	Version          string
 	SentinelPassword string
-
-	EnableSecondaryStorage bool
-
-	// number of seconds. when job's delay second is greater than pumpStorageThresh,
-	// it will be written to storage if enabled
-	SecondaryStorageThresholdSeconds int64
-}
-
-func (c *Config) HasSecondaryStorage() bool {
-	return c.SecondaryStorage != nil
 }
 
 func (rc *RedisConf) validate() error {
@@ -104,9 +94,6 @@ func (rc *RedisConf) validate() error {
 	if rc.DB < 0 {
 		return errors.New("the pool db must be greater than 0 or equal to 0")
 	}
-	if rc.EnableSecondaryStorage && rc.SecondaryStorageThresholdSeconds < minSecondaryStorageThresholdSeconds {
-		return errors.New("write to secondary storage threshold required at least 1 hour")
-	}
 	return nil
 }
 

config/config_test.go

@@ -33,10 +33,4 @@ func TestRedisConfig_Validate(t *testing.T) {
 	if err := conf.validate(); err != nil {
 		t.Fatalf("no error was expected, but got %v", err)
 	}
-
-	conf.EnableSecondaryStorage = true
-	conf.SecondaryStorageThresholdSeconds = 10
-	if err := conf.validate(); err == nil {
-		t.Fatalf("validate addr error was expected, but got nil")
-	}
 }

engine/job.go

@@ -5,9 +5,7 @@ import (
 	"encoding/binary"
 	"encoding/json"
 	"errors"
-	"google.golang.org/protobuf/proto"
 
-	"github.com/bitleak/lmstfy/engine/model"
 	"github.com/bitleak/lmstfy/uuid"
 )
 
@@ -51,26 +49,6 @@ type jobImpl struct {
 	_elapsedMS int64
 }
 
-// NewJobFromReq creates a new job with its body and attributes being marshalled
-func NewJobFromReq(req *CreateJobReq) Job {
-	if req.ID == "" {
-		req.ID = uuid.GenUniqueJobIDWithDelay(req.Delay)
-	}
-	jobData, err := marshalJobBody(req.Body, req.Attributes)
-	if err != nil {
-		return &jobImpl{}
-	}
-	return &jobImpl{
-		namespace: req.Namespace,
-		queue:     req.Queue,
-		id:        req.ID,
-		body:      jobData,
-		ttl:       req.TTL,
-		delay:     req.Delay,
-		tries:     req.Tries,
-	}
-}
-
 // NOTE: there is a trick in this factory, the delay is embedded in the jobID.
 // By doing this we can delete the job that's located in hourly AOF, by placing
 // a tombstone record in that AOF.
@@ -229,11 +207,3 @@ func (j *jobImpl) MarshalText() (text []byte, err error) {
 func (j *jobImpl) GetDelayHour() uint16 {
 	return 0
 }
-
-func marshalJobBody(body []byte, attrs map[string]string) ([]byte, error) {
-	job := &model.JobData{
-		Data:       body,
-		Attributes: attrs,
-	}
-	return proto.Marshal(job)
-}