Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of publish/consume with job attributes in client side #227

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

git-hulk
Copy link
Member

This PR introduces the new API: PublishJob and RePublishJob to allow
the use of the job attributes and mark the old API as deprecated. But we
don't add the new API for the batch publish since we think it's not a rigorous
implementation and don't encourage users to use that.

@git-hulk git-hulk changed the title Add support of publish/consume with job attributes Add support of publish/consume with job attributes in client side Jul 12, 2024
Copy link
Contributor

@Lance726 Lance726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@calvinxiao calvinxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 7c2834a into bitleak:master Jul 12, 2024
5 checks passed
@git-hulk
Copy link
Member Author

@Lance726 @calvinxiao Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants