This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Support secondary only connections #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jehiah Ready for review |
| # Try primary first | ||
| h = self._primary | ||
| else: | ||
| h = fresh.pop() | ||
| h = random.sample(fresh, len(fresh))[0] |
There was a problem hiding this comment.
is this any different from random.choice(fresh) ?
There was a problem hiding this comment.
actually ... you are right, I was thinking about consuming the sequence all the time, but have come to picking a random member, so choice() will be a much cleaner way to do this, thanks!
|
@manover nice work on this change. aside from some small renames, 👍 |
jehiah
added a commit
that referenced
this pull request
Apr 22, 2013
Support secondary only connections
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow option of connections to secondary only members of replica set