Skip to content

Commit

Permalink
query: Ignoring SetQueryFilter. (#10)
Browse files Browse the repository at this point in the history
Use value verbatim from SetQueryFilter if set.
Does not require MetricDescriptor to be set on MetricQuery type.

Resolves: #9
  • Loading branch information
jharshman authored Aug 9, 2021
1 parent 66ab871 commit 1e822c5
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions tsplot/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (mq *MetricQuery) request() (*monitoringpb.ListTimeSeriesRequest, error) {
return nil, errors.New("MetricQuery missing GCE Project")
}

if mq.MetricDescriptor == "" {
if mq.MetricDescriptor == "" && mq.queryFilter == "" {
return nil, errors.New("MetricQuery missing MetricDescriptor")
}

Expand All @@ -66,13 +66,16 @@ func (mq *MetricQuery) request() (*monitoringpb.ListTimeSeriesRequest, error) {
mq.EndTime = &now
}

if mq.queryFilter == "" {
mq.queryFilter = fmt.Sprintf(DefaultQueryFilter, mq.MetricDescriptor)
// Complete override of timeSeriesRequestFilter. Use verbatim.
// Resolves: https://github.com/bitly/tsplot/issues/9
timeSeriesRequestFilter := fmt.Sprintf(DefaultQueryFilter, mq.MetricDescriptor)
if mq.queryFilter != "" {
timeSeriesRequestFilter = mq.queryFilter
}

tsreq = monitoringpb.ListTimeSeriesRequest{
Name: fmt.Sprintf("projects/%s", mq.Project),
Filter: mq.queryFilter,
Filter: timeSeriesRequestFilter,
Interval: &monitoringpb.TimeInterval{
EndTime: timestamppb.New(*mq.EndTime),
StartTime: timestamppb.New(*mq.StartTime),
Expand Down

0 comments on commit 1e822c5

Please sign in to comment.