v2: Ditch Query helpers. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharshman
force-pushed
the
v2
branch
2 times, most recently
from
2ee8f60
to
739d6af
Compare
|
|
|
Testing multiple TimeSeries graphed on a single plot. |
|
Looks similar enough to the GCM plot |
|
|
|
Okay there are a few tasks left on this - The first is that the function that returns colors for the lines can return colors that are very very hard to see. |
|
|
jharshman
force-pushed
the
v2
branch
2 times, most recently
from
e229e26
to
2067ba5
Compare
This PR focuses around simplification of the tsplot package. Moving away from something that was rather perscriptive in the type of Query that you could make and towards a package that can accept a Time Series or Time Series Itterator from the Google Metrics API and return a rendered graph of those Time Series.
|
LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses around simplification of the tsplot package. Moving away
from something that was rather perscriptive in the type of Query that
you could make and towards a package that can accept a Time Series or
Time Series Itterator from the Google Metrics API and return a rendered
graph of those Time Series.